jean/metamorpov
jean
/
metamorpov
1
0
Fork 0
Code Issues 7 Pull Requests Releases 3 Wiki Activity

Have extension icon change color by what tab is open to indicate whether its enabled or not #29

New Issue
Closed
opened 2025-02-22 16:23:51 -05:00 by jean · 6 comments
jean commented 2025-02-22 16:23:51 -05:00
Owner
Copy Link
No description provided.
jean pinned this 2025-06-26 22:11:28 -04:00
jean commented 2025-06-27 19:48:40 -04:00
Author
Owner
Copy Link

https://github.com/classvsoftware/example-chrome-extension/blob/master/components/modify-toolbar-icon/modify-toolbar-icon.js

https://github.com/classvsoftware/example-chrome-extension/blob/master/components/modify-toolbar-icon/modify-toolbar-icon.js
jean commented 2025-06-28 01:31:22 -04:00
Author
Owner
Copy Link
  • Add neutral (not disabled/enabled) icon version
  • Add service worker script to update the icon when changing tabs
  • Add service worker to manifest.json
  • Add service worker to rollup config
  • Set icon to dark/light when changing theme
  • Set icon to enabled/disabled/invalid when moving to an enabled/disabled/invalid tab (Bitwarden does this)
  • Set icon when enabling/disabling a tab (in popup, maybe?)
  • Add theme_icons to manifest.json, even though they're Firefox-only :(

Here's an example of this being done for Chrome with background scripts, which have been deprecated with Manifest V3.

- [x] Add neutral (not disabled/enabled) icon version - [x] Add service worker script to update the icon when changing tabs - [x] Add service worker to manifest.json - [x] Add service worker to rollup config - [x] [Set icon](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/browserAction/setIcon) to dark/light when changing theme - [x] Set icon to enabled/disabled/invalid when moving to an enabled/disabled/invalid tab (Bitwarden does this) - [x] Set icon when enabling/disabling a tab (in popup, maybe?) - [x] [Add theme_icons](https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/action) to manifest.json, even though they're Firefox-only :( [Here](https://stackoverflow.com/questions/58880234/toggle-chrome-extension-icon-based-on-light-or-dark-mode-browser)'s an example of this being done for Chrome with background scripts, which have been deprecated with Manifest V3.
jean commented 2025-06-28 23:17:55 -04:00
Author
Owner
Copy Link

Update: only Chrome works with service workers. Firefox wants background pages still.

Update: only Chrome works with service workers. Firefox wants background pages still.
jean commented 2025-06-29 01:05:04 -04:00
Author
Owner
Copy Link

Here is a service worker version of this, for reference.

[Here](https://github.com/Zren/RecentBookmarksPopup/blob/master/src/serviceworker.js) is a service worker version of this, for reference.
jean commented 2025-06-29 02:20:25 -04:00
Author
Owner
Copy Link
  • Make sure that theme is being set when extension is first loaded and not just set to default
- [x] Make sure that theme is being set when extension is first loaded and not just set to default
jean commented 2025-06-29 03:19:03 -04:00
Author
Owner
Copy Link
  • Test on Chrome
- [x] Test on Chrome
jean closed this issue 2025-06-29 16:11:04 -04:00
jean unpinned this 2025-06-29 16:11:10 -04:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
main
1.3.0
1.2.0
1.1.0
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: jean/metamorpov#29
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?